Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use schema.json instead of zoteroTypeSchemaData.js #15

Open
dstillman opened this issue Jun 30, 2022 · 0 comments
Open

Use schema.json instead of zoteroTypeSchemaData.js #15

dstillman opened this issue Jun 30, 2022 · 0 comments

Comments

@dstillman
Copy link
Member

No one is going to remember to run build_typeSchemaData.html in a Zotero instance after updating schema and restarting and then copy the file into this submodule.

zoteroTypeSchemaData.js is currently used for Zotero.CachedTypes, Zotero.ItemTypes and Zotero.CreatorTypes. I believe the only thing in zoteroTypeSchemaData that's not in schema.json is icon filenames. Those would arguably make sense in schema.json, but that gets into some complicated questions about icon sizes, PNG vs. SVG, etc., so for now we should probably just port those functions to use schema.json and keep this file around for the icon info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant