Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User not prompted for keyPassphrase if in secure array of ssh profile #1770

Closed
JillieBeanSim opened this issue Jul 31, 2023 · 2 comments · Fixed by #2214 or #2232
Closed

User not prompted for keyPassphrase if in secure array of ssh profile #1770

JillieBeanSim opened this issue Jul 31, 2023 · 2 comments · Fixed by #2214 or #2232
Assignees
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.

Comments

@JillieBeanSim
Copy link
Contributor

Describe the bug

If user has ssh keys in place and includes the path to it as value for privateKey then adds the keyPassphrase to the ssh profile's secure array an error is returned Cannot parse privateKey: Encrypted private OpenSSH key detected, but no passphrase given but user wasn't prompted for the keyPassphrase. If the tag --keyPassphrase is used with the command or the passphrase is stored under properties in plain text the connection works.

Expected and actual results

User should be prompted for secure values, especially passwords/passphrases, if not already stored securely in keystore.

-->
Describe your environment

  • Zowe CLI version installed (run command zowe --version): 7.17.0
  • Installed plug-ins and their version numbers (run command zowe plugins list --short):
  • Node.js and NPM versions installed (run node --version, npm --version): node v16.19.0; npm v9.7.2
  • Environment variables in use:
  • Operating system and version: macos
  • Shell/terminal (bash, cmd, powershell, etc...):
  • Daemon mode enabled or disabled: disabled
  • For more information, see Gathering information to troubleshoot Zowe CLI

Additional context

@JillieBeanSim JillieBeanSim added bug Something isn't working new The issue wasn't triaged yet labels Jul 31, 2023
@github-actions
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@JTonda JTonda added priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex. and removed new The issue wasn't triaged yet labels Aug 16, 2023
@adam-wolfe adam-wolfe mentioned this issue Nov 20, 2023
26 tasks
@adam-wolfe adam-wolfe mentioned this issue Feb 26, 2024
23 tasks
@zFernand0
Copy link
Member

As part of this issue, we should:

  • Make sure to prompt for every property in the secure arrays that are used by the command
  • Prompt for key passphrase if its specified in the secure array and there is no value for it
  • Make sure to test that no secure properties are stored in plain text when removed from the secure array and execute in a command that requires set property

@jace-roell jace-roell self-assigned this Jul 10, 2024
@jace-roell jace-roell linked a pull request Aug 1, 2024 that will close this issue
4 tasks
@jace-roell jace-roell linked a pull request Aug 12, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-medium Bug where workaround exists or that doesn't prevent the usage of Zowe. Just makes it more complex.
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

4 participants