Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace yamljs dependency with maintained alternative #2163

Closed
recaph opened this issue May 30, 2024 · 5 comments
Closed

replace yamljs dependency with maintained alternative #2163

recaph opened this issue May 30, 2024 · 5 comments

Comments

@recaph
Copy link

recaph commented May 30, 2024

Looks like yamljs author is not active in a long time. Please replace with popular library like https://github.com/nodeca/js-yaml or more maintained alternative like https://www.npmjs.com/package/yaml. There are multiple violations reported on this dependency in Blackduck.

"yamljs": "0.3.0",

Comment on yaml.js repo from 2017:
``
Development of this library has slowed-down

I am still using yaml.js in production for some projects, it works fine in all the situations I needed it. That said, I am not actively working with raw javascript environments (mostly using haxe now, if you are curious), thus I don't have much bandwidth to actively provide support to the posted issues asking for new features or bugfixes that don't affect my own use cases of the library. If this situation is an issue for you, I suggest you use js-yaml which is a great and pretty feature-complete yaml parser and dumper for javascript. Pull Requests are still welcome, as long as they don't break the current set of unit tests!

Thanks 🙏
``

@gejohnston
Copy link
Member

yamljs will be removed from the Zowe V3 release, when changes to create a different project-level base profile name are merged into our next branch.

Removal of yamljs from Zowe V2 is a separate consideration.

@recaph
Copy link
Author

recaph commented May 31, 2024

@gejohnston good to know... could you point me to the branch name where profile name changes are happening or link to the commit?

@gejohnston
Copy link
Member

@recaph The branch to change the generated base profile name is still local on my PC. Once unit tests pass, I will open a pull request for that change. I will post a link to that PR at that time.

@gejohnston
Copy link
Member

@recaph Other priorities have postponed the testing of the project-level base profile name. So, I have not created a pull request yet. The branch containing those changes is:

https://github.com/zowe/zowe-cli/tree/projectBase

@gejohnston
Copy link
Member

Closed as part of Pull request "Generate different base profile names for global and project configs" #2194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

No branches or pull requests

2 participants