Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance secureFields method to optionally return arg value, type, and name #2206

Closed
t1m0thyj opened this issue Jul 24, 2024 · 2 comments · Fixed by #2241
Closed

Enhance secureFields method to optionally return arg value, type, and name #2206

t1m0thyj opened this issue Jul 24, 2024 · 2 comments · Fixed by #2241
Assignees
Labels
enhancement New feature or request priority-high Production outage - this quarter or at least next quarter

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Jul 24, 2024

For the VSCode user I want to offer a webview that shows the existing values and allow the user to over type.

If we use secureFields and we are provided the argValue, argType and argName - that would suffice.
With that, we can present existing values and allow the user to overtype and then we can put the updates path values back into the vault in the same manner that zowe config secure —gc does currently.

I will be able to validate that an entered value is correct - if it is argType user I can ensure that it is a valid TSO format. If for example rejectunauthorized were a secure field and therefore presented by secureFields , I can ensure that the field is treated as a Boolean and validated as such.
I don’t thing much more would be necessary beyond that.

Originally posted by @davidkjackson54 in #2185 (comment)

@t1m0thyj t1m0thyj added enhancement New feature or request new The issue wasn't triaged yet labels Jul 24, 2024
Copy link

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@davidkjackson54
Copy link

Providing this additional information would also allow zowe config secure —gc to also then take advantage of the information.
Currently that zowe command does no validation of the entered user data so a user entering a TSO userid currently can enter any value even if invalid. Also existing values are not presented to the user yet the user can skip over existing values without actually being aware of what that value is. This update would allow existing values to be presented and allow the user to change or skip at least aware of the current value.

@JTonda JTonda added priority-medium Not functioning - next quarter if capacity permits and removed new The issue wasn't triaged yet labels Jul 29, 2024
@adam-wolfe adam-wolfe added priority-high Production outage - this quarter or at least next quarter and removed priority-medium Not functioning - next quarter if capacity permits labels Aug 20, 2024
@zFernand0 zFernand0 self-assigned this Aug 23, 2024
@zFernand0 zFernand0 linked a pull request Aug 23, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-high Production outage - this quarter or at least next quarter
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

5 participants