Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zowe plugins list registry qualification #63

Closed
JTonda opened this issue Oct 9, 2018 · 6 comments · Fixed by #2189
Closed

zowe plugins list registry qualification #63

JTonda opened this issue Oct 9, 2018 · 6 comments · Fixed by #2189
Assignees
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases

Comments

@JTonda
Copy link

JTonda commented Oct 9, 2018

From @dkelosky on May 17, 2018 14:15

If a plugin is installed via a scoped registry, the scoped registry is not displayed on the zowe plugins list command.

For example, if scoped package xyz where installed from a registry qualified by the scoped zowe the displayed registry could be misleading.

In other words if @zowe/xyz were installed from a registry hosted on JFrog, it could be displayed as though it came from npmjs:

$ zowe plugins list

Installed plugins:

-- pluginName: @zowe/xyz
 -- package: @zowe/xyz
 -- version: 0.0.1-20
 -- registry: https://registry.npmjs.org/

Copied from original issue: gizafoundation/brightside#77

@JTonda
Copy link
Author

JTonda commented Oct 9, 2018

From @AHumanFromCA on May 17, 2018 14:17

This requires an enhancement to imperative.

@JTonda
Copy link
Author

JTonda commented Oct 9, 2018

From @AHumanFromCA on August 20, 2018 14:4

Perhaps a quick way to address this is when listing or installing plugins we could output every scoped registry we find. Then we could change the --registry flag to be --non-scoped-registry or keep the flag the same and change the doc so that people understand what is happening. Otherwise you would say that the registry would be bintray but that is also a lie since only the scoped packages are downloaded from there, everything else is pulled from the npm registry.

@davidkjackson54
Copy link

Our CLI component is not hosted on a registry at all yet is shown as the above example on a zowe plugins list - incorrectly in my view. I tried adding private: true to package.js but it made no difference.

@t1m0thyj
Copy link
Member

t1m0thyj commented Jun 25, 2021

From an internal conversation:

Perhaps we could make use of metadata that NPM adds to the plugin's package.json at install time? For example, in my ~/.zowe/plugins/installed/node_modules/@broadcom/jclcheck-for-zowe-cli/package.json file there is a line:
"_resolved": "https://registry.npmjs.org/@broadcom/jclcheck-for-zowe-cli/-/jclcheck-for-zowe-cli-1.1.2.tgz",

Edit: This metadata appears to no longer be generated by npm@8 😢

@namanpatel1112 namanpatel1112 self-assigned this Jul 14, 2021
@namanpatel1112 namanpatel1112 removed their assignment Jul 28, 2021
@zFernand0 zFernand0 changed the title bright plugins list registry qualification zowe plugins list registry qualification Aug 12, 2022
@zFernand0 zFernand0 added bug Something isn't working imperative labels Aug 12, 2022
@gejohnston gejohnston added the priority-medium Not functioning - next quarter if capacity permits label Oct 10, 2022
@adam-wolfe adam-wolfe mentioned this issue Jul 9, 2023
19 tasks
@zFernand0 zFernand0 added severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases and removed imperative labels Jan 18, 2024
@adam-wolfe
Copy link
Contributor

As recently discussed, it may be better to not display the registry at all.

@adam-wolfe adam-wolfe mentioned this issue Apr 5, 2024
23 tasks
@JTonda
Copy link
Author

JTonda commented Apr 24, 2024

--no-location as a new flag
npm view before npm installing the package
proper error handling around npm view command
npm-package-arg to be be used to determine if registry vs .tgz install.

@jace-roell jace-roell linked a pull request Jul 2, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority-medium Not functioning - next quarter if capacity permits severity-low Bug that makes the usage of the Zowe less convenient but doesn't impact key use cases
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

8 participants