-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerous bugs/regression when updating from Zowe Explorer v2.18.0 -> Zowe Explorer v3 for extenders #3089
Comments
v3_bug.mp4 |
Hey @FrankSu1996 a fix was issued for the inclusion of base profile in the creation of team config, the pre-release version with date 202404242037 is pretty old. Please try again and can verify fix in a newer pre-release. The project level file name changes was done to be more consistent with Zowe CLI, more work was also done via CLI and our project with handling global vs project level profiles as well. Please share any feedback after testing a newer version. Thanks! For RSE profiles a Zowe v3 compatible version of IBM Z Open Editor would be needed for the profile types registration and inclusion in the team configuration creation. |
I tried with version v3.0.0-next.202409091409. Although I see the base profiles now, I do not see our extended profile. Did the way extenders register with zowe-explorer-api change? This is how we currently register, and we do so with no errors. Note that if I call ProfilesCache.getConfigArray(), it will include our profile type still. |
Hey @FrankSu1996 I know some extenders pass their profile type into the ...getExplorerExtenderApi().reloadProfiles(); and this calls profilesCache.refresh(). I am not sure if the following call to your refreshProfilesCache() method is duplicating the efforts done by it previous call. |
After doing some more testing, I've isolated multiple issues as a result of upgrading from Zowe Explorer/zowe-explorer-api v2.18.0 to the latest v3.0.0-next.202409091409. Nothing in our extension code has changed. Here are the regressions and bugs I have experienced:
Again, with Zowe Explorer/zowe-explorer-api v2.18.0, none of these above issues occur. Since zowe-explorer-api merely re-exports whatever Zowe Explorer exports as API, we cannot prevent users from updating to ZE v3, and thus breaking extenders as it is currently. The best we can do is issue an error message and not register with ZE v3. |
Hey @FrankSu1996 closing this issue as the original problems stated in description are fixed in newer pre-release. I did create individual bugs for the list shared in comment. Thanks again for testing and adopting early to help us find these bugs ❤ |
Confirmed today using Zowe Explorer 3.0.0-next.202409251932 that the issues are resolved. Thanks for the quick fixes! |
Describe the bug
Once a Team config is created using the Add Profile to ... View UI, the team config file is missing base and rse profiles, and subsequent clicks on the treeview "+" icon issues a vscode error message like:
Error running command zowe.uss.addSession: command 'zowe.uss.addSession' not found. This is likely caused by the extension that contributes zowe.uss.addSession.
To Reproduce
Expected behavior
The created team configuration file is missing base/rse profiles, and subsequent clicks to the "+" icon will issue a vscode error message. Only restarting the workbench will remove the error message.
I've also noticed that project level configs are not created as zowe.config.user.json anymore, instead it is now zowe.config.json. This seems to mess with edit functionality, as the edit team config also will not open the correct team config if both global/project are present.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: