Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages disappear after they're sent #2413

Closed
zingmars opened this issue Apr 26, 2018 · 13 comments
Closed

Messages disappear after they're sent #2413

zingmars opened this issue Apr 26, 2018 · 13 comments
Assignees
Labels
a-data-sync Zulip's event system, event queues, staleness/liveness bug

Comments

@zingmars
Copy link

When I send a private message they don't appear at the bottom of the conversation view and there is no way to forcefully refresh this view. In fact, there doesn't seem to be a way to forcefully refresh anything, which was a bit annoying when I had to restart the app to get a reactivated user to show up in the users view.

Video of the messages disappearing: https://youtu.be/n1sIXJQYqRc

Using Android 8.0 on a OnePlus 3. App version v12.4.84.

@pulkonet
Copy link
Collaborator

Are you sure you're on the latest version? This bug was fixed in this version update via 08d1df and I was also unable to reproduce this using the same environment.

@zingmars
Copy link
Author

Yup. Reinstalled from github to test. Issue still happens.

@borisyankov
Copy link
Contributor

Thanks for reporting this. I will test very thoroughly, though the issue you are reporting was fixed by the exact commit @pulkonet is mentioning.

@Yoshi8765
Copy link

Yoshi8765 commented May 7, 2018

I still get a form of this in my android version (also similar to #2277 ). My current version is v12.4.84 .
I just started talking to a user on mobile via PM, and every single message I wrote would not show up. only when they respond, and I click the notification that comes up, will my sent messages (along with their new message) show up.
This user isn't someone I just started talking to, there's already past message history.
It's been happening with basically every PM I send.
I tried to fully close the app by tapping my recents button, and swiping left/right on zulip to close it, and reopen. It didn't work.

@Yoshi8765
Copy link

https://streamable.com/a2x3h It's partially fixed on 13.2.85

@Yoshi8765
Copy link

strangely enough, no issue when I sent a PM to a different person. https://streamable.com/zoqyd

@borisyankov
Copy link
Contributor

@Yoshi8765 I think I know one case where this will be happening and will be fixing it next.
Hope it is only this single case needed fixing.

@borisyankov
Copy link
Contributor

@Yoshi8765 I did test extensively and what I expected might be the cause is working. So I am not sure how to reproduce.

The red bug you are getting might be something related to message encoding (a wild educated guess) but I have no idea what is going on.

@Yoshi8765
Copy link

@borisyankov ok, if that's the case I'll closely watch the app and try to report with as much info as possible if it happens again.

@borisyankov
Copy link
Contributor

Thanks. 👍
I hope it never appears, but if it does and we can reproduce, this will be a very high priority fix.

@gnprice
Copy link
Member

gnprice commented Jul 20, 2018

The reports in this thread have a lot in common with the later issue #2539 .

Like #2539 , I think the bug we recently diagnosed as the cause of #2800 (where our event queue on the server goes away, and we never notice and get a new one) might be the cause of these failures too. There's just one detail that puzzles me on that theory:

only when they respond, and I click the notification that comes up, will my sent messages (along with their new message) show up.

I wouldn't expect this to fix things. So at least on the occasion when this behavior was observed, there may have been a different bug involved.

@sschueller
Copy link

sschueller commented Oct 25, 2018

I have this issue on 18.0.99 android. Messages I write only appear after I go out of the chat and back in. It happens every time. Server is a zulipchat.com instance.

@gnprice gnprice added a-compose/send Compose box, autocomplete, camera/upload, outbox, sending and removed a-Android labels Nov 7, 2018
@gnprice gnprice changed the title [Android] Messages disappear after they're sent Messages disappear after they're sent Nov 7, 2018
@gnprice
Copy link
Member

gnprice commented Nov 7, 2018

Thanks @sschueller for that report!

I suspect the issue you're seeing on 18.0.99 is unrelated to the one that affected us in April and up to July, though it has similar (quite bad) symptoms -- we didn't hear any reports like this for a couple of months, so in retrospect I think this did turn out to be the same issue as #2539.

So I'll file a new issue with your report momentarily, and then close this one.

@gnprice gnprice closed this as completed Nov 7, 2018
@gnprice gnprice added a-message list a-data-sync Zulip's event system, event queues, staleness/liveness and removed a-compose/send Compose box, autocomplete, camera/upload, outbox, sending a-message list labels Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-data-sync Zulip's event system, event queues, staleness/liveness bug
Projects
None yet
Development

No branches or pull requests

7 participants