Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark messages as EDITED or MOVED in the UI for multiple messages at a time. #1366

Open
Subhasish-Behera opened this issue Mar 30, 2023 · 0 comments
Labels
area: event handling How events from the server are responded to area: message editing area: UI General user interface update

Comments

@Subhasish-Behera
Copy link
Contributor

Subhasish-Behera commented Mar 30, 2023

Currently, the model.py code handles the edit of the message from which the event originated. But an edit originating from one message can affect multiple messages (for eg. propagation mode edits/topic-rename change edits).

Eg: here is a message event
event {'type': 'update_message', 'user_id': 25554, 'edit_timestamp': 1680095186, 'message_id': 1536316, 'rendering_only': False, 'stream_name': 'test here', 'stream_id': 7, 'propagate_mode': 'change_later', 'orig_subject': 'zt_2025', 'subject': 'zt_2025_', 'topic_links': [], 'message_ids': [1536316, 1536317], 'flags': ['read'], 'id': 7}

For updating the message label for multiple messages the message_ids key of the update_message event has to be used.

Note: It is advisable to work on this after merging #T1331

@mounilKshah mounilKshah added area: event handling How events from the server are responded to area: message editing labels Jun 13, 2023
@Subhasish-Behera Subhasish-Behera changed the title Enable the update_message_event handling function to handle edits of more than one message. Mark messages as EDITED OR MOVED in the UI for multiple messages at a time. Jun 14, 2023
@Subhasish-Behera Subhasish-Behera changed the title Mark messages as EDITED OR MOVED in the UI for multiple messages at a time. Mark messages as EDITED or MOVED in the UI for multiple messages at a time. Jun 14, 2023
@Subhasish-Behera Subhasish-Behera added the area: UI General user interface update label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: event handling How events from the server are responded to area: message editing area: UI General user interface update
Projects
None yet
Development

No branches or pull requests

2 participants