Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple sessions creating the same payment result in the same hash returned #41

Open
bmilleker opened this issue Jan 29, 2019 · 0 comments

Comments

@bmilleker
Copy link

There is an issue I have been encountering when two separate sessions are submitting the same transaction at the same time. What happens is that one transaction succeeds but the same hash is returned to both sessions. This is not what I thought would happen. What I think is going on is the same sequence number is being used in both transactions. I still don't understand why one doesn't fail though.

I resolved this issue by adding in a unique ID to the memo field of the transactions. So even if the sequence number is the same, the transactions are different, and one of the transactions will fail for being out of sequence.

I don't know if this is an issue or more of an FYI. I don't have more of a fix aside from using the memo field.

@bmilleker bmilleker changed the title Multiple sessions creating the same payment Multiple sessions creating the same payment result in the same hash returned Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant