Skip to content
This repository has been archived by the owner on Sep 10, 2019. It is now read-only.

Ok/Cancel buttons in Modal example are <spans> when rendered #197

Closed
cvrebert opened this issue Dec 4, 2014 · 1 comment
Closed

Ok/Cancel buttons in Modal example are <spans> when rendered #197

cvrebert opened this issue Dec 4, 2014 · 1 comment

Comments

@cvrebert
Copy link
Contributor

cvrebert commented Dec 4, 2014

  1. Open the Modal docs page
  2. Click the main "Open modal" button
  3. View the DOM tree of the modal that appears
  4. Observe that the Ok/Cancel buttons are:
<span class="button" zf-close="">Ok</span>
<span class="button" zf-close="">Cancel</span>

<span> aren't semantically appropriate for buttons. These should be <button>s or <a>s or at least have an ARIA role="button".

@gakimball
Copy link
Contributor

Went ahead and converted them to anchors. As far as accessibility, it's something we'll have to wait to look at farther down the road when the framework is more solid.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants