Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in console when clicking on 'No Match' or clicking enter when there are no results #80

Closed
lihi-intsights opened this issue Sep 26, 2017 · 5 comments
Labels

Comments

@lihi-intsights
Copy link

When typing something that doesn't exist on the values list and clicking on the 'No Match' in the list, an error appears in the console saying: 'Cannot read property 'original' of undefined'.

Does it should be clickable at all? there is no reason that someone could click the 'No Match' label that is shown when the typing did not match anything.

Also, the 'No Match' disappears after some chars where typed, and so the error is shown also when there isn't a 'No Match' label but the enter button is clicked.

@mrsweaters mrsweaters added the bug label Sep 26, 2017
@mrsweaters
Copy link
Collaborator

I would agree that the expected behavior is that it should not be clickable.

@lihi-intsights
Copy link
Author

Is a fix going to be uploaded soon?
Thanks!

@mrsweaters
Copy link
Collaborator

I'm not going to be able to get to it myself this week, but I'm willing to review and merge a pull request.

@mrsweaters
Copy link
Collaborator

Fixed in https://github.com/zurb/tribute/releases/tag/3.1.0. Thank you!

@lihi-intsights
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants