[Bug] Unable to find IGDB search results with revision in filename

[helgehatt]

Description

No cover is found for games with (rev-Vx.x) in their file name.

Example

Search IGDB action with file name Donkey Kong Country (U) (rev-V1.2) [!].smc yields no results.

Search IGDB action with file name Donkey Kong Country (U) [!].smc yields nine results.

[gantoine]

Alright so (rev-V1.2) is not a supporter revision format, as most systems expect [Rev 1.2]. In your case the scan is crashing when it hits that unexpected string. I'll fix the crash in an upcoming PR, but you'll need to update your ROM titles to a supported format.

[helgehatt]

Okay, but that format is from your «Tags support» section which states:

Revision tags must be prefixed with "rev-": (rev-1) / (rev-v2) / (rev-whatever)

so maybe update the documentation as well?

Why not just remove everything in parenthesis and brackets in the query to IGDB? Then the query string would just be Donkey Kong Country. E.g. re.sub(r" \(.+?\)", "", Path(filename).stem) and similarly for brackets. Edit: Nevermind, I can see that’s what you’re doing.

The format (Vx.x) should ideally be supported and recognized as revision as it is widely used in ROMs downloaded from archive.org:

elif re.match("^v\d+\.\d+$", tag, re.IGNORECASE) is not None:
    rev = tag

Bonus: Update regex to "^v\d+(\.\d+)?$" to support (Vx) as well.

[gantoine]

Yeah that sounds reasonable, I'll take a crack at that regex and update my PR (and the docs) accordingly. 👍🏼

[helgehatt]

Would be nice if (V1.2) was recognized as revision without rev similar to how (U) is recognized as region without reg.

[gantoine]

Something to consider in the future, but for the time being the current structure should cover most cases.