Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain Cycle #241

Closed
piercifani opened this issue Apr 17, 2018 · 3 comments
Closed

Retain Cycle #241

piercifani opened this issue Apr 17, 2018 · 3 comments

Comments

@piercifani
Copy link
Contributor

There seems to be a retain cycle in ImageSlideshow between the ZoomAnimatedTransitioningDelegate and the slideshow itself

This leads to the items shown in the slideshow not being released, which leads to high memory pressure, which leads to crashes :)
@piercifani
Copy link
Contributor Author

This patch seems to fix this issue Privalia@1441652

@zvonicek
Copy link
Owner

Hi, thank you for reporting the bug and providing the patch. I'll release a new version with the fix today.

@zvonicek
Copy link
Owner

Your fix is now merged to master, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piercifani @zvonicek