Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default host to :: #3348

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: set default host to :: #3348

merged 2 commits into from
Oct 17, 2023

Conversation

robertsLando
Copy link
Member

Fixes #3347

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6535802558

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.415%

Totals Coverage Status
Change from base Build 6531979441: 0.0%
Covered Lines: 3681
Relevant Lines: 18298

💛 - Coveralls

@robertsLando robertsLando merged commit 68cc58e into master Oct 17, 2023
11 checks passed
@robertsLando robertsLando deleted the default-host branch October 17, 2023 07:55
@cloud-aware
Copy link

just an FYI - this change broke my docker-compose environment where I have ipv6 disabled. I had to fix by setting an environment variable of HOST and setting it to the value of the container IP

@bpawulski
Copy link

bpawulski commented Oct 19, 2023

@Skullduggeryism I'm probably having similar problem to yours.
After updating the container to 9.2 it's not starting with the error:

2023-10-18 16:19:03.238 WARN STORE: scenes.json not found Error: listen EAFNOSUPPORT: address family not supported :::8091 at Server.setupListenHandle [as _listen2] (node:net:1723:21) at listenInCluster (node:net:1788:12) at doListen (node:net:1937:7) at processTicksAndRejections (node:internal/process/task_queues:83:21)

Could you please give a little bit more details was it the same as you have seen and how you fixed it. Thank you!

robertsLando added a commit that referenced this pull request Oct 19, 2023
@robertsLando
Copy link
Member Author

Can someone of you give a try to: #3362 ?

I can build a test docker container for it

@bpawulski
Copy link

@robertsLando Sure, I can. Send me please the new container.

@robertsLando
Copy link
Member Author

I have triggered this workflow: https://github.com/zwave-js/zwave-js-ui/actions/runs/6571215103

Once it ends, you can use docker test tag

@bpawulski
Copy link

@robertsLando : just pulled the test tag Digest: sha256:2014a9da749da02d3548e3cb091ae9f185af565fed18e899e3dadfcbfc1da8da

And it works fine (after 3 min of interacting with it). Thank you!

@robertsLando
Copy link
Member Author

@bpawulski Do you have ipv6 disabled?

@bpawulski
Copy link

@robertsLando: Yes i do
bartek@ubuntuser:~$ cat /sys/module/ipv6/parameters/disable
1

@robertsLando
Copy link
Member Author

robertsLando commented Oct 19, 2023

Thanks for your report! Need to figure out if ipv6 only works too

@cloud-aware
Copy link

@Skullduggeryism I'm probably having similar problem to yours. After updating the container to 9.2 it's not starting with the error:

2023-10-18 16:19:03.238 WARN STORE: scenes.json not found Error: listen EAFNOSUPPORT: address family not supported :::8091 at Server.setupListenHandle [as _listen2] (node:net:1723:21) at listenInCluster (node:net:1788:12) at doListen (node:net:1937:7) at processTicksAndRejections (node:internal/process/task_queues:83:21)

Could you please give a little bit more details was it the same as you have seen and how you fixed it. Thank you!

That is correct, I got the error "EAFNOSUPPORT: address family not supported :::8091"

To fix (in docker-compose environment), you should be able to just add the following environment variable:

environment:
  - HOST=0.0.0.0

However, for some reason that did not work for me so I hard-coded an IP address for this container, and then made HOST that IP address.

@robertsLando
Copy link
Member Author

@Skullduggeryism try with 9.2.2

@cloud-aware
Copy link

@Skullduggeryism try with 9.2.2

confirmed that I no longer need a workaround in 9.2.2.

Removed hard-coded IP address and removed HOST environment variable setting and container is working as expected.

@robertsLando
Copy link
Member Author

Perfect, thanks for your feedback 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Also listen to IPv6 by default
4 participants