Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): preferred scales alignment #3494

Merged
merged 3 commits into from
Dec 23, 2023
Merged

fix(ui): preferred scales alignment #3494

merged 3 commits into from
Dec 23, 2023

Conversation

alexojegu
Copy link
Contributor

Correctly align preferred scales with log enabled on settings -> Zwave.

Currently:
Captura desde 2023-12-22 14-41-31

After:
Captura desde 2023-12-22 14-43-06

@alexojegu
fix: preferred scales alignment
f5a2f14 
Correctly align `preferred scales` with `log enabled` on settings -> Zwave.
@coveralls
Copy link

coveralls commented Dec 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7303598531

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.208%
Totals Coverage Status
Change from base Build 7297927674: 0.0%
Covered Lines: 3735
Relevant Lines: 17888
💛 - Coveralls

@robertsLando robertsLando changed the title fix: preferred scales alignment fix: preferred scales alignment Dec 22, 2023
@robertsLando robertsLando changed the title fix: preferred scales alignment fix(ui): preferred scales alignment Dec 22, 2023
@robertsLando
Copy link
Member

I don't remember now, does it align well on MD sceeens too?

@alexojegu
Copy link
Contributor Author

I see it well on 900px screens using Chrome 120.0.6099.109:
Captura desde 2023-12-22 20-32-12

But on SM screens I see bad others as Max files or Inclusion/Exclusion timeout:
Captura desde 2023-12-22 20-43-09

I will also fix this in the PR.

@alexojegu
Copy link
Contributor Author

@zwave-js-bot fix lint

robertsLando
robertsLando approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit 74d7c31 into zwave-js:master Dec 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertsLando robertsLando robertsLando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexojegu @coveralls @robertsLando @zwave-js-bot