Unable to change zwave config

[zackbcom]

Checklist

• I am not using Home Assistant. Or: a developer has told me to come here.
• I have checked the troubleshooting section and my problem is not described there.
• I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.13.0

ZwaveJS version

12.9.1

Describe the bug

Unable to save config if zniffer is disabled.

prob needs another check in there for zwave enabled, zniffer disabled.

		differentPorts() {
			return (
                                (this.newZwave.enabled &&
					!this.newZniffer.enabled ) ||
				(this.newZwave.enabled &&
					this.newZniffer.enabled &&
					this.newZwave.port !== this.newZniffer.port) ||
				'Zniffer and Z-Wave ports must be different.'
			)
		}

SOURCE -

zwave-js-ui/src/views/Settings.vue

Line 1976 in 1c36405

(this.newZwave.enabled &&

To Reproduce

have zwave enabled, have zniffer disabled. make change to zwave configs, save.

Expected behavior

able to save zwave config.

Additional context

[robertsLando]

@zackbcom Did you used the same port on zniffer? I mean if you enable it and clear the port and then disable it again does it works?

[robertsLando]

This is better:

differentPorts() {
			return (
				!this.newZwave.enabled ||
				!this.newZniffer.enabled ||
				this.newZwave.port !== this.newZniffer.port ||
				'Zniffer and Z-Wave ports must be different.'
			)
		},

[zackbcom]

@zackbcom Did you used the same port on zniffer? I mean if you enable it and clear the port and then disable it again does it works?

I tried both ways. wouldn't save with same port though.

New updates fixes it. thanks! Currently testing the zniffer, so far it's awesome.

[robertsLando]

@zackbcom Thanks for your feedback 🙏🏼