Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: always show driver/app logs on debug UI even when log settings are disabled #3884

Merged
merged 9 commits into from
Sep 17, 2024
Merged

feat: always show driver/app logs on debug UI even when log settings are disabled #3884

merged 9 commits into from
Sep 17, 2024

Conversation

robertsLando
Copy link
Member

Fixes #3875

@robertsLando robertsLando changed the title fix: intercept logs using stream transports feat: allow to always see driver/app logs on debug UI Sep 17, 2024
@robertsLando robertsLando changed the title feat: allow to always see driver/app logs on debug UI feat: always show driver/app logs on debug UI even when log settings are disabled Sep 17, 2024
@robertsLando robertsLando merged commit 40a557e into master Sep 17, 2024
9 checks passed
@robertsLando robertsLando deleted the better-logs-intercept branch September 17, 2024 09:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10900706236

Details

  • 12 of 26 (46.15%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 21.085%
Changes Missing Coverage Covered Lines Changed/Added Lines %
api/app.ts 0 3 0.0%
api/lib/ZwaveClient.ts 0 11 0.0%
Totals Coverage Status
Change from base Build 10900349716: 0.05%
Covered Lines: 3924
Relevant Lines: 19786
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use log transport instead of capturing console for driver logs
2 participants
@robertsLando @coveralls