fix(discovery): define units for scene and configuration values #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and for scene values, use the correct template because the value is a JSON object that also includes the units, but nests the actual value one level deeper
ccutrer
force-pushed
the
discovery-scene-units
branch
from
649e117
to
ac31d5f
Compare
Pull Request Test Coverage Report for Build 10949118309Details
💛 - Coveralls |
| @@ -1336,6 +1336,10 @@ export default class Gateway { | |||
| valueId.property, | |||
| valueId.propertyKey, | |||
| ) | |||
| if (valueId.value?.unit) { | |||
| cfg.discovery_payload.value_template = | |||
| "{{ value_json.value.value | default('') }}" | |||
There was a problem hiding this comment.
I think you have a typo here?
Suggested change
| "{{ value_json.value.value | default('') }}" | |
| "{{ value_json.value | default('') }}" |
There was a problem hiding this comment.
No, this is intentional, and the critical part of this change. Example data from MQTT:
zwave/Garage/Loft_Stairwell_Lights/38/0/duration
{"time":1726797698474,"value":{"value":0,"unit":"seconds"}}Notice value is nested within value.
There was a problem hiding this comment.
Oh didn't know about that! Thanks for clarification
robertsLando
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And for scene values, use the correct template because the value is a JSON object that also includes the units, but nests the actual value one level deeper.