Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): visualize running firmware updates #2117

Merged
merged 2 commits into from
Dec 29, 2021
Merged

feat(ui): visualize running firmware updates #2117

merged 2 commits into from
Dec 29, 2021

Conversation

robertsLando
Copy link
Member

@robertsLando robertsLando commented Dec 29, 2021

Fixes #2110

Schermata da 2021-12-29 16-41-05

@robertsLando
Copy link
Member Author

@LordMike Cannot test this my own, could you give this a try?

@coveralls
Copy link

coveralls commented Dec 29, 2021

Pull Request Test Coverage Report for Build 1634547138

  • 0 of 33 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 27.318%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/nodes-table/nodes-table.js 0 1 0.0%
lib/ZwaveClient.ts 0 32 0.0%
Totals Coverage Status
Change from base Build 1633279615: -0.05%
Covered Lines: 3635
Relevant Lines: 14027

💛 - Coveralls

@LordMike
Copy link
Contributor

Can you build an image for it?

I've recently formatted and my docker setup is broken :/

... I could take this opportunity and actually fix it ... :P

@robertsLando
Copy link
Member Author

Can you build an image for it?

I could merge this to master and then you can use master tag, I tried it my self by emulating an update via code and it seems working so shouldn't create any problem

@LordMike
Copy link
Contributor

I'll run a :dev later to test it out then .. :)

@robertsLando
Copy link
Member Author

@LordMike dev doesn't exists anymore, it has been replaced by master tag

@robertsLando robertsLando merged commit 6238696 into master Dec 29, 2021
@robertsLando robertsLando deleted the feat#2110 branch December 29, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Visualize running firmware updates
3 participants