Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: entity names with empty location #218

Merged
merged 1 commit into from
Jan 12, 2021
Merged

fix: entity names with empty location #218

merged 1 commit into from
Jan 12, 2021

Conversation

robertsLando
Copy link
Member

Fixes #162

@robertsLando robertsLando mentioned this pull request Jan 12, 2021
Closed
@robertsLando
Copy link
Member Author

@chilicheech Let me know if this fixes your problem

@coveralls
Copy link

Pull Request Test Coverage Report for Build 480045836

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 24.757%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Gateway.js 1 2 50.0%
Totals Coverage Status
Change from base Build 479769329: 0.009%
Covered Lines: 1939
Relevant Lines: 8001
💛 - Coveralls

aretakisv
aretakisv approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@aretakisv aretakisv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsLando robertsLando merged commit bfbda11 into master Jan 12, 2021
@robertsLando robertsLando deleted the entityNames branch January 12, 2021 14:58
@chilicheech
Copy link
Contributor

This solved the problem. Thanks so much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aretakisv aretakisv aretakisv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] hass entity names are now being prefixed with -
4 participants
@robertsLando @coveralls @chilicheech @aretakisv