Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discovery missing targetValue when runs first time #54

Merged
merged 2 commits into from
Dec 7, 2020

Conversation

varet80
Copy link
Collaborator

@varet80 varet80 commented Dec 7, 2020

During initial discovery, while the setTopic value is undefined there is
an issue which arises with an nill value for command_topic on hass
discovery. This issue comes due to the "split" node compared to previous
driver, which combined both.

Check if node is ready before discovering

@coveralls
Copy link

coveralls commented Dec 7, 2020

Pull Request Test Coverage Report for Build 406059615

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 27.935%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/Gateway.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
lib/Gateway.js 2 20.5%
Totals Coverage Status
Change from base Build 406057957: 0.1%
Covered Lines: 1865
Relevant Lines: 6793

💛 - Coveralls

Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @billiaz :)

@robertsLando robertsLando merged commit 4076085 into master Dec 7, 2020
@robertsLando robertsLando deleted the fix#nodeDiscovery branch December 7, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants