add node Location and node Name on Value metadata

[varet80]

MQTT is a powerfull tool. Using data from to generate graphs is a good approach.
In tools like influxdb, you rely on the whole Payload read. Adding node Location and Name in metadata is a way to use and analyse the data

Added nodeLocation and nodeName as metadata, to help searching/storing data.

[coveralls]

Pull Request Test Coverage Report for Build 413157189

• 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 27.915%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/Gateway.js	0	5	0.0%

Totals
Change from base Build 408182097:	-0.02%
Covered Lines:	1865
Relevant Lines:	6798

---

💛 - Coveralls

[robertsLando]

@billiaz IMO this should be added in a configuration options like "add node info to payload" (available only for json and valueId payloads). Adding them to valueIds is not a good practice as it will be repeated. It should be added only before sending the payload

[robertsLando]

Needs to be added only to the payload and make it configurable using options in the ui

[varet80]

Needs to be added only to the payload and make it configurable using options in the ui

I suspect this https://github.com/zwave-js/zwavejs2mqtt/blob/03d4d0e6cb69a82156f588346ede71572ca85a2a/lib/Gateway.js#L291 is a good point to build the code.

Maybe is a better spot I cannot currently see

[robertsLando]

I would add this even for the json type, maybe after the switch:

if(typeof data === 'object' && this.config.includeNodeInfo) {
  data.nodeName = node.name
  data.nodeLocation = node.loc
}

[varet80]

I will add this. but just before this, there is a data.value which obviously has to work only if this is an object.

maybe is better to make it

if (typeof data === 'object') {
  data.value = tmpVal
  if(this.config.includeNodeInfo) {
    data.nodeName = node.name
    data.nodeLocation = node.loc
  }
}

[robertsLando]

I mean add this after the switch

[varet80]

I understand, my question is. if data.value assumes data is object, why only check the nodeName/Location in our case?
shouldn't data.value also be checked for the same typeof?

[robertsLando]

nope, in the switch we check for the payload type, later if the payload is an object and the includeNodeInfo flag is true we add the node info

[robertsLando]

LGTM. Thanks @billiaz 🙏