Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add support for optional genius api host address #8

Closed
vitaliikravets opened this issue Jan 15, 2021 · 4 comments
Closed

Please add support for optional genius api host address #8

vitaliikravets opened this issue Jan 15, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@vitaliikravets
Copy link

I would like to use this library from browser.
In order to fight the CORS , improve performance and lower the load on actual API, I am setting up a CDN that will have the same domain name as my website but will redirect all calls to genius.com.
@zyrouge zyrouge added the enhancement New feature or request label Jan 16, 2021
@zyrouge
Copy link
Owner

zyrouge commented Jan 16, 2021

Soon™

@zyrouge
Copy link
Owner

zyrouge commented Jan 18, 2021

🎉Added in v4.2.0

@zyrouge zyrouge closed this as completed Jan 18, 2021
@vitaliikravets
Copy link
Author

Wow @zyrouge that was a very prompt response, thanks!
Is genius website URL (www.genius.com) also configurable? To be able to fetch the lyrics from the browser?

@zyrouge
Copy link
Owner

zyrouge commented Jan 18, 2021

Wow @zyrouge that was a very prompt response, thanks!
Is genius website URL (www.genius.com) also configurable? To be able to fetch the lyrics from the browser?

Yeah options.origin.url

This was referenced Mar 9, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaliikravets @zyrouge