Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

long-running-notifications should use the edit:after-command hook #21

Open
krader1961 opened this issue Sep 20, 2021 · 1 comment
Open

long-running-notifications should use the edit:after-command hook #21

krader1961 opened this issue Sep 20, 2021 · 1 comment

Comments

@krader1961
Copy link
Contributor

This question was posed by @dcuadrado on IM an hour ago:

in the notifier is there a way to know if the process failed? I'd like it to say something out loud if the command failed

The answer is, no, given the current implementation. However, if the implementation were changed to use the edit:after-command hook introduced by commit elves/elvish@e2f8100 it could both report sub-second durations and the status of the command; i.e., whether or not it failed and if it failed how it failed.
@zzamboni
Copy link
Owner

Good idea. I don't have a lot of time at the moment to work on this, but PRs are welcome 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zzamboni @krader1961