feat: dumpconfig also dump disabled plugin (#4480)

eggjs · Sep 23, 2020 · cc80c6a · cc80c6a
1 parent 1d32771
commit cc80c6a
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 2 deletions.
diff --git a/lib/egg.js b/lib/egg.js
@@ -372,7 +372,7 @@ class EggApplication extends EggCore {
       ignoreList = [];
     }
 
-    const json = extend(true, {}, { config: this.config, plugins: this.plugins });
+    const json = extend(true, {}, { config: this.config, plugins: this.loader.allPlugins });
     utils.convertObject(json, ignoreList);
     return {
       config: json,

diff --git a/test/fixtures/apps/dumpconfig/config/plugin.js b/test/fixtures/apps/dumpconfig/config/plugin.js
@@ -0,0 +1,3 @@
+'use strict';
+
+exports.static = false;
diff --git a/test/lib/core/loader/config_loader.test.js b/test/lib/core/loader/config_loader.test.js
@@ -14,7 +14,7 @@ describe('test/lib/core/loader/config_loader.test.js', () => {
   it('should get middlewares', async () => {
     app = utils.app('apps/demo');
     await app.ready();
-    assert.deepEqual(app.config.coreMiddleware.slice(0, 7), [
+    assert.deepStrictEqual(app.config.coreMiddleware.slice(0, 7), [
       'meta',
       'siteFile',
       'notfound',

diff --git a/test/lib/egg.test.js b/test/lib/egg.test.js
@@ -167,6 +167,21 @@ describe('test/lib/egg.test.js', () => {
     });
   });
 
+  describe('dump disabled plugin', () => {
+    let app;
+    before(async () => {
+      app = utils.app('apps/dumpconfig');
+      await app.ready();
+    });
+    after(() => app.close());
+
+    it('should works', async () => {
+      const baseDir = utils.getFilepath('apps/dumpconfig');
+      const json = readJson(path.join(baseDir, 'run/application_config.json'));
+      assert(!json.plugins.static.enable);
+    });
+  });
+
   describe('dumpConfig() dynamically', () => {
     let app;
     before(() => {