fix: duration is not always calculated for task executions #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 |
Signed-off-by: csirius <davidtruong.dev@gmail.com>
govalt
force-pushed
the
885-duration-not-calculated
branch
from
2af7e56 to
b387ef8
Compare
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage ? 66.66%
=========================================
Files ? 348
Lines ? 7242
Branches ? 1226
=========================================
Hits ? 4828
Misses ? 2414
Partials ? 0 Continue to review full report at Codecov.
|
|
Congrats on merging your first pull request! 🎉 |
flyte-bot
added a commit
that referenced
this pull request
Aug 19, 2021
## [0.22.1](http://github.com/lyft/flyteconsole/compare/v0.22.0...v0.22.1) (2021-08-19) ### Bug Fixes * duration is not always calculated for task executions ([#185](http://github.com/lyft/flyteconsole/issues/185)) ([2e12418](http://github.com/lyft/flyteconsole/commit/2e124189d39f09375fb90b20e562a1575e88405d))
|
🎉 This PR is included in version 0.22.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed the
unknownis being present for bothstart timeanddurationin task details panel for nodes.Added
last updatedto be shown instead if both of above fields are absent in API response.Type
Are all requirements met?
Complete description
Created a
fallbackoption whenstarted_atanddurationfields are not present in the API response.Tracking Issue
fixes flyteorg/flyte#885
Follow-up issue
NA