fix: auth role to be aligned with launch plan and be editable by user #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=========================================
Coverage ? 63.52%
=========================================
Files ? 365
Lines ? 7924
Branches ? 1390
=========================================
Hits ? 5034
Misses ? 2890
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
govalt
force-pushed
the
relaunch-persist
branch
from
e4431e5 to
19f7e05
Compare
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
flyte-bot
added a commit
that referenced
this pull request
Nov 19, 2021
## [0.31.3](http://github.com/lyft/flyteconsole/compare/v0.31.2...v0.31.3) (2021-11-19) ### Bug Fixes * auth role to be aligned with launch plan and be editable by user ([#236](http://github.com/lyft/flyteconsole/issues/236)) ([afc2ae4](http://github.com/lyft/flyteconsole/commit/afc2ae4ef8767e74753217cfc62faf057626993a))
|
🎉 This PR is included in version 0.31.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: csirius 85753828+csirius@users.noreply.github.com
TL;DR
Display the original execution IAM or k8s role under "advanced options" in the launch form. Roles can be changed according to the
launch planif it has auth role in it; users can edit those roles manually. This fix also adds additional functionality to the launch from with the support of Annotations and LabelsType
Are all requirements met?
Complete description
Make the
Advanced optionsin relaunch form shows the original execution IAM or k8s role.Also those roles could be changed according to the
launch planchanges if it has auth role in it.And user can edit those roles manually.
Tracking Issue
fixes flyteorg/flyte#1737
Follow-up issue
NA