-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add advanced launch options to execution details #242
Conversation
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=========================================
Coverage ? 63.64%
=========================================
Files ? 366
Lines ? 7950
Branches ? 1392
=========================================
Hits ? 5060
Misses ? 2890
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# [0.33.0](http://github.com/lyft/flyteconsole/compare/v0.32.0...v0.33.0) (2021-12-07) ### Features * add advanced launch options to execution details ([#242](http://github.com/lyft/flyteconsole/issues/242)) ([711600d](http://github.com/lyft/flyteconsole/commit/711600d3eefe67451362d7c7454e2b8b4ea39d76))
🎉 This PR is included in version 0.33.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: csirius 85753828+csirius@users.noreply.github.com
TL;DR
Add advanced launch options to execution details page.
Type
Are all requirements met?
Complete description
Add
Service Account
,Raw Output Prefix
, andParallelism
to execution details page.Tracking Issue
fixes flyteorg/flyte#1761
Follow-up issue
NA