feat: Remove disable auth var #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
=========================================
Coverage ? 63.12%
=========================================
Files ? 370
Lines ? 8108
Branches ? 1433
=========================================
Hits ? 5118
Misses ? 2990
Partials ? 0 Continue to review full report at Codecov.
|
govalt
reviewed
Dec 9, 2021
| maxRenderDepth: 2 | ||
| maxRenderDepth: 1 |
There was a problem hiding this comment.
Is this one related to this PR?
govalt
approved these changes
Dec 9, 2021
flyte-bot
added a commit
that referenced
this pull request
Dec 9, 2021
# [0.34.0](http://github.com/lyft/flyteconsole/compare/v0.33.1...v0.34.0) (2021-12-09) ### Features * Remove disable auth var ([#251](http://github.com/lyft/flyteconsole/issues/251)) ([a701c08](http://github.com/lyft/flyteconsole/commit/a701c085be4eea3f72ef3bd46694b9253aa3addf))
|
🎉 This PR is included in version 0.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
DISABLE_AUTH.The reasoning behind this decision is that the app itself does not use this value and is simply pass along with requests to Admin as
withCredentials. However, this value has consequence on the server side as it informsAccess-control; specifically if cross domain cookies can be set which can cause issues when connecting to Admin (and has no affect otherwise).see: https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials
Edit:
Type
Are all requirements met?
Complete description
Removes
DISABLE_AUTHfrom flyteconsole.Tracking Issue
NA
Follow-up issue
NA