Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: timeline view #265

Merged
merged 25 commits into from
Feb 15, 2022
Merged

feat: timeline view #265

merged 25 commits into from
Feb 15, 2022

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Jan 15, 2022 •
edited by anrusina
Loading

TL;DR

Add timeline view for execution details page.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

MVP for timeline view.

Tracking Issue

Partial work for: flyteorg/flyteconsole#302

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Jan 15, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@15878ab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     flyteorg/flyte#265   +/-   ##
=========================================
  Coverage          ?   64.40%           
=========================================
  Files             ?      392           
  Lines             ?     8843           
  Branches          ?     1588           
=========================================
  Hits              ?     5695           
  Misses            ?     3148           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15878ab...ab08323. Read the comment docs.

@govalt govalt changed the title Feat/timeline view feat: timeline view Jan 15, 2022
@anrusina anrusina requested review from a team, Pianist038801, anrusina and jsonporter and removed request for a team January 16, 2022 00:24
anrusina
anrusina previously approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@anrusina anrusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

  • Performed basic smoke test on already finished executions
  • All nits, are recommended but not mandatory changes.

anrusina
anrusina reviewed Jan 16, 2022
View reviewed changes
@govalt govalt force-pushed the feat/timeline-view branch from 0f3c5c0 to fa0715f Compare January 20, 2022 22:02
anrusina
anrusina previously approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@anrusina anrusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From code perspective looks good, haven't done smoke test on the latest code

anrusina
anrusina previously approved these changes Jan 21, 2022
View reviewed changes
@govalt govalt force-pushed the feat/timeline-view branch from 637bfea to 1dc138f Compare January 21, 2022 19:12
govalt and others added 12 commits February 10, 2022 16:56
@govalt @anrusina
feat: basic UI for gantt chart
642fd9a 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
feat: add basic timeline
a810e9e 
Signed-off-by: csirius <davidtruong.dev@gmail.com>
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@anrusina
feat: timeline mvp
274b656 
Signed-off-by: csirius <davidtruong.dev@gmail.com>
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@anrusina
feat: update unexecuted nodes view
c9e8f70 
Signed-off-by: csirius <davidtruong.dev@gmail.com>
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: chartjs-plugin-datalabels typing update
9614a89 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: unit test failure issue
c239699 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@anrusina
chore: fix tests
9b0fd3f 
Signed-off-by: Nastya Rusina <nastya@union.ai>
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: optimize percentage usage
cf9834f 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@anrusina
feat: nested children view for timeline view
3cc500f 
Signed-off-by: csirius <davidtruong.dev@gmail.com>
@govalt @anrusina
fix: nested nodes view
e30e9bf 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: address pr comments
caacfcf 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: color as enums
b291177 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
csirius and others added 12 commits February 10, 2022 16:56
@anrusina
fix: line up taskname and timeline chart
cf67ce5 
Signed-off-by: csirius <davidtruong.dev@gmail.com>
@govalt @anrusina
fix: broken refetch mechanism
2dfa169 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: uglify webpack plugin issue
603b162 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: sort mechanism for node executions
dec0fa3 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@govalt @anrusina
fix: remove console log
4777e28 
Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@anrusina
fix scroll issue
d886e9b
@anrusina
timeline tasknames
ceee8ae
@anrusina
remove console
dac9234
@anrusina
execution type added
b12b024
@anrusina
chore: rebase on top of master, add prettier change to allo 120 symbols
f5fc5da 
Signed-off-by: Nastya Rusina <nastya@union.ai>
@anrusina
style: move name to left side, include template name
cfd2b61 
Signed-off-by: Nastya Rusina <nastya@union.ai>
@anrusina
chore: simplify code, fix vertical scroll + nodeexecutions info
9a7688d 
Signed-off-by: Nastya Rusina <nastya@union.ai>
@anrusina
chore: storybook fix
ab08323 
Signed-off-by: Nastya Rusina <nastya@union.ai>
@anrusina anrusina merged commit f499895 into master Feb 15, 2022
@anrusina anrusina deleted the feat/timeline-view branch February 15, 2022 05:27
flyte-bot added a commit that referenced this pull request Feb 15, 2022
@flyte-bot
chore(release): Release 0.43.0 [skip ci]
e5b7169 
# [0.43.0](http://github.com/lyft/flyteconsole/compare/v0.42.1...v0.43.0) (2022-02-15)

### Features

* timeline view ([#265](http://github.com/lyft/flyteconsole/issues/265)) ([f499895](http://github.com/lyft/flyteconsole/commit/f499895fb99878766118634e2fe256a4dfa98a7e))
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.43.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrusina anrusina anrusina approved these changes

@Pianist038801 Pianist038801 Awaiting requested review from Pianist038801 Pianist038801 was automatically assigned from flyteorg/fe-engineers

@jsonporter jsonporter Awaiting requested review from jsonporter jsonporter was automatically assigned from flyteorg/fe-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@govalt @flyte-bot @anrusina