Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#281): allow to collapse/expand workflow version section #patch #282

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

anrusina
Copy link
Contributor

@anrusina anrusina commented Feb 8, 2022

In workflow view we now allow user to collapse/expand workflow versions section. User choice would be persistent between pages (by LocalStorage)

video: https://share.getcloudapp.com/kpu4e0l1

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Added useLocalCache hook, which uses local storage to persist user settings
  • Uncoupled EntityDetails page from WorkflowVersionDetailsContainer. Now they are independent pages
  • Moved "Launch[Entity]" form into EntityDetailsHeader, so it will leave along side "Launch[Entity]" button.

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/281

Signed-off-by: Nastya Rusina nastya@union.ai

Signed-off-by: Nastya Rusina <nastya@union.ai>
@anrusina anrusina requested review from a team, jsonporter and govalt and removed request for a team and govalt February 8, 2022 21:34
@@ -0,0 +1,49 @@
// More info on Local storage: https://developer.mozilla.org/en-US/docs/Web/API/Window/localStorage
import { useState } from 'react';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update README

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@95128b5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #282   +/-   ##
=========================================
  Coverage          ?   65.20%           
=========================================
  Files             ?      380           
  Lines             ?     8406           
  Branches          ?     1500           
=========================================
  Hits              ?     5481           
  Misses            ?     2925           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95128b5...b26f4b4. Read the comment docs.

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: In Workflow details page allow to collapse "Recent Workflow Versions" section, save default as collapsed
3 participants