feat: adding route and navigation to the task details page #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## single-task-execution #97 +/- ##
=========================================================
+ Coverage 67.54% 67.67% +0.13%
=========================================================
Files 372 372
Lines 6021 6030 +9
Branches 945 945
=========================================================
+ Hits 4067 4081 +14
+ Misses 1954 1949 -5
Continue to review full report at Codecov.
|
BobNisco
approved these changes
Sep 11, 2020
schottra
added a commit
that referenced
this pull request
Oct 8, 2020
* refactor: make workflow details generic so it can be used for tasks (#96) * refactor: make workflow details generic so it can be used for tasks * chore: cleanup and moving tests over * feat: adding route and navigation to the task details page (#97) * Refactor Launch form to use a state machine (#99) * refactor: filling out details of the state machine for launch * refactor: checkpoint * refactor: mostly finished wiring of machine to component state * refactor: more work to get form component migrated to using machine * refactor: cleaning up state for selectors * fix: type error due to patch version upgrade * refactor: trying a flat state structure * fix: getting all tests passing again * chore: cleanup and docs * chore: pull request feedback * refactor: Make launch state and components generic (#100) * refactor: splitting launch machine into two separate types * refactor: move shared state out to component * refactor: use composition to create workflow form * refactor: update usage of LaunchWorkflowForm -> LaunchForm * chore: cleanup and fix tests * feat: Add Task support to Launch form (#101) * feat: add task support in launch components * test: updating launch form tests to handle task cases * fix: remaining broken tests * Cleanup work for launching single task executions. (#102) * feat: add support for launch tasks in entity details view * fix: correctly map initial parameters when relaunching * fix: correct parent name and back link in execution details page * fix: pass through referenceExecution when relaunching * test: check rendering of referenceExecution * test: adding tests for relaunch flow
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Oct 8, 2020
# [0.13.0](http://github.com/lyft/flyteconsole/compare/v0.12.1...v0.13.0) (2020-10-08) ### Features * Improve UX for Single Task Executions ([#103](http://github.com/lyft/flyteconsole/issues/103)) ([d0335dc](http://github.com/lyft/flyteconsole/commit/d0335dc1f86b98b30011e63d686b8168262d3bbd)), closes [#96](http://github.com/lyft/flyteconsole/issues/96) [#97](http://github.com/lyft/flyteconsole/issues/97) [#99](http://github.com/lyft/flyteconsole/issues/99) [#100](http://github.com/lyft/flyteconsole/issues/100) [#101](http://github.com/lyft/flyteconsole/issues/101) [#102](http://github.com/lyft/flyteconsole/issues/102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds plumbing and interaction to allow users to navigate to the details page for a Task. It works pretty much the same as the behavior for Workflows.
Links, and added chevrons to indicate that they navigate to details upon click.routesto allow navigating to TaskDetails view.EntityDetailsHeaderso that the back link changes depending on what type of entity we are rendering (so that clicking back from a Task takes you to the Tasks section instead of Workflows)