fix: check number exclude NaN (#30)

node-modules · Nov 23, 2017 · 3693861 · 3693861
1 parent 67d8cf6
commit 3693861
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -221,7 +221,7 @@ function checkInt(rule, value) {
  */
 
 function checkNumber(rule, value) {
-  if (typeof value !== 'number') {
+  if (typeof value !== 'number' || isNaN(value)) {
     return this.t('should be a number');
   }
   if (rule.hasOwnProperty('max') && value > rule.max) {

diff --git a/test/index.test.js b/test/index.test.js
@@ -115,6 +115,12 @@ describe('parameter', function () {
       parameter.validate(rule, value)[0].message.should.equal('should be a number');
     });
 
+    it('should check NaN error', function () {
+      var value = { number: NaN };
+      var rule = { number: 'number' };
+      parameter.validate(rule, value)[0].message.should.equal('should be a number');
+    });
+
     it('should check max error', function () {
       var value = { number: 101 };
       var rule = { number: {type: 'number', max: 100, min: 1 }};