fix: list accepted CSV mime types #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
|
sorry for the delay in testing this one. I don't know why it has been in the back burner for so long but, given the time frame that has passed since its inception, is this still relevant with the current admin structure @aldeed ? |
|
@manueldelreal The main thing would be to make sure these end up in new admin UI, but the easiest way to do that right now is to continue with testing and merging them here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the changes from reactioncommerce/reaction#5785 in 3.0 stream.
Testing
On Products page, verify that you can only drop/select CSV and text files when filtering by CSV. Verify that CSV files generated by Microsoft Excel work when viewing the page on Windows OS.