Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly display total order amount #217

Merged
merged 2 commits into from
Feb 21, 2020
Merged

fix: correctly display total order amount #217

merged 2 commits into from
Feb 21, 2020

Conversation

willopez
Copy link
Member

Resolves #201
Impact: minor
Type: bugfix

Issue

In the orders table, the order total only took into account the amount of the first payment.

Solution

Calculate an order's total by summing all payments

Testing

  1. Place an order and split the payment into multiple payments
  2. Verify to order total is correctly rendered in the orders table.

@willopez
fix: correctly display total order amount
141fcb7 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
manueldelreal
manueldelreal approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total is now reflected on table rather than just the first payment.

@willopez
refactor: use order total provided by API
1cfdcc2 
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez dismissed mikemurray’s stale review February 20, 2020 16:48

Suggestion implemented

mikemurray
mikemurray approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 29d1b8c into trunk Feb 21, 2020
@mikemurray mikemurray deleted the fix-table-orders-total branch February 21, 2020 23:30
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

@manueldelreal manueldelreal manueldelreal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orders table total only reflect first payment
3 participants
@willopez @mikemurray @manueldelreal