Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting views various issues reported in #238 #239

Merged
merged 11 commits into from
Mar 13, 2020

Conversation

willopez
Copy link
Member

@willopez willopez commented Mar 5, 2020

Resolves #238
Impact: minor
Type: bugfix|refactor

Issue

There are various issues with the new settings views, this PR seeks to fix all those and add some necessary CSS styles polish.

Testing

  1. Clicking on a setting link should add a selected style to the link
  2. Verify all other styling issues reported on Issues found with new settings pages #238 are resolved.

Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
@willopez willopez marked this pull request as ready for review March 9, 2020 22:15
@willopez willopez requested a review from mikemurray March 9, 2020 22:15
Signed-off-by: Will Lopez <will.lopez77@gmail.com>
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We can revisit the nav issues in Catalyst with a reusable component

@mikemurray mikemurray merged commit f1a2704 into trunk Mar 13, 2020
@mikemurray mikemurray deleted the fix-setting-views-various-ussues branch March 13, 2020 17:18
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues found with new settings pages
2 participants