Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product editor fixes #240

Merged
merged 29 commits into from
Mar 13, 2020
Merged

Product editor fixes #240

merged 29 commits into from
Mar 13, 2020

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Mar 6, 2020 •
edited
Loading

Resolves #237
Impact: minor
Type: feature|bugfix

Issue

There are various issues with the product editor outlined in this ticket #237

Solution

Fixed

  • Variants in the sidebar are highlighted when active
  • Inconsistent notification. Now all toasts use notistack
  • Archived variants and options seem to work. Not sure if I fixed it, or if some other issue was at play
  • Refactor GQL queries/mutations to use fragments and moved out of hook file
  • In the useProduct hook, skip queries that require shopId if the shopId is not available

Not fixed

Breaking changes

none

Testing

  1. Ensure variants and options are highlighted
  2. Check the code for the queries/mutations
  3. Ensure variants and options can be archived

@mikemurray
feat: highlight active tree item
4603229 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add left spacing
3dc222a 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
fix: use notistack snackbars
d212e7e 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add product variant GQL fragment
25dc649 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add product with variants and options GQL fragment
40363ba 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add archive product variants mutation definition
8b41548 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add clone product variants mutation definition
51f18c6 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add create product variant mutation definition
0b8407a 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add update product variant mutation definition
68c8d4c 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add update product variant prices mutation definition
7747e9e 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: add product query definition
7dd281a 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
refactor: import queries and mutations
b1686e6 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: use product with variants fragment
9ebd0b2 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
chore: remove unused file
ec8dd1c 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
chore: remove unused file
cd27437 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
chore: remove unused file
3b8646e 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
chore: remove unused file
bd102d5 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
fix: skip query when shopId is undefined
7d2c642 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
fix: skip queries when shopId is undefined
6cd0407 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
chore: remove commented code
b457733 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: adjust padding
fdb84e0 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: adjust padding
f897134 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: update list item selected styles
a7426e0 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
feat: remove padding
4181295 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
fix: use variant fragment
1a91d68 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
chore: update lockfile
2904f3a 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
fix: padding
4f70af9 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray
fix: styles
0663feb 
Signed-off-by: Mike Murray <hellomikemurray@gmail.com>
@mikemurray mikemurray changed the title [WIP] Product editor fixes Product editor fixes Mar 12, 2020
@mikemurray mikemurray marked this pull request as ready for review March 12, 2020 16:36
@willopez
Copy link
Member

Related API issue here: reactioncommerce/reaction#6148

willopez
willopez approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
An issue in the API repo has been created to track a new issue related to duplicating products

@willopez willopez merged commit d736860 into trunk Mar 13, 2020
@redscare redscare mentioned this pull request Mar 15, 2020
Closed
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
Merged
@Akarshit Akarshit deleted the fix-237-mikemurray-product-editor branch February 4, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New product editor issues
2 participants
@mikemurray @willopez