ci: upload jaq executable to GitHub releases #102
Conversation
This reverts commit daac337.
| - name: Build | ||
| if: runner.os != 'Linux' | ||
| run: cargo build --release --locked --target ${{ matrix.target }} | ||
| shell: bash | ||
| - name: Build with cross | ||
| if: runner.os == 'Linux' | ||
| run: cross build --release --locked --target ${{ matrix.target }} | ||
| shell: bash |
There was a problem hiding this comment.
The commands are different if closely looked at because they use CROSS only on Linux.
It is certainly possible to combine them into one step using if, but I am concerned that it would reduce readability.
| - name: Create artifact for Linux and macOS | ||
| shell: bash | ||
| if: runner.os != 'Windows' | ||
| run: | | ||
| export ARTIFACT_NAME="jaq-${{ github.ref_type == 'tag' && github.ref_name || 0 }}-${{ matrix.target }}.tar.gz" | ||
| echo "ARTIFACT_NAME=${ARTIFACT_NAME}" >>"$GITHUB_ENV" | ||
| cd target/${{ matrix.target }}/release | ||
| tar czf "../../../${ARTIFACT_NAME}" jaq ../../../LICENSE-MIT -C ../../../ README.md | ||
|
|
||
| - name: Create artifact for Windows | ||
| shell: bash | ||
| if: runner.os == 'Windows' | ||
| run: | | ||
| export ARTIFACT_NAME="jaq-${{ github.ref_type == 'tag' && github.ref_name || 0 }}-${{ matrix.target }}.zip" | ||
| echo "ARTIFACT_NAME=${ARTIFACT_NAME}" >>"$GITHUB_ENV" | ||
| cd target/${{ matrix.target }}/release | ||
| 7z a "../../../${ARTIFACT_NAME}" jaq.exe ../../../LICENSE-MIT ../../../README.md |
There was a problem hiding this comment.
Can you merge these two steps? Perhaps using something like:
with:
version: ${{ github.ref_type == 'tag' && github.ref_name || 0 }}
archive: ${{ runner.os == 'Windows' && 'zip' || 'tar.gz' }}
# ... (similar for 7z vs. tar, .exe etc.)
run: |
export ARTIFACT_NAME="jaq-${{ version }}-${{ matrix.target }}.${{ archive }}"
# ...
There was a problem hiding this comment.
I am sorry but I do not know how to do it.
| cd target/${{ matrix.target }}/release | ||
| tar czf "../../../${ARTIFACT_NAME}" jaq ../../../LICENSE-MIT -C ../../../ README.md |
There was a problem hiding this comment.
Omit the cd and adapt the paths accordingly?
There was a problem hiding this comment.
Sorry, I couldn't figure out how to do the same thing without using cd.
Feel free to edit this PR to modify it.
|
Do you know how I can test this workflow without creating a release? |
There was a problem hiding this comment.
Do you know how I can test this workflow without creating a release?
Unfortunately I don't think there is a way to do that.
I am publishing the results of running this workflow in my fork for now so you can check it out.
Or, you should be able to copy this branch to a new repository and run it yourself.
| - name: Build | ||
| if: runner.os != 'Linux' | ||
| run: cargo build --release --locked --target ${{ matrix.target }} | ||
| shell: bash | ||
| - name: Build with cross | ||
| if: runner.os == 'Linux' | ||
| run: cross build --release --locked --target ${{ matrix.target }} | ||
| shell: bash |
There was a problem hiding this comment.
The commands are different if closely looked at because they use CROSS only on Linux.
It is certainly possible to combine them into one step using if, but I am concerned that it would reduce readability.
| - name: Create artifact for Linux and macOS | ||
| shell: bash | ||
| if: runner.os != 'Windows' | ||
| run: | | ||
| export ARTIFACT_NAME="jaq-${{ github.ref_type == 'tag' && github.ref_name || 0 }}-${{ matrix.target }}.tar.gz" | ||
| echo "ARTIFACT_NAME=${ARTIFACT_NAME}" >>"$GITHUB_ENV" | ||
| cd target/${{ matrix.target }}/release | ||
| tar czf "../../../${ARTIFACT_NAME}" jaq ../../../LICENSE-MIT -C ../../../ README.md | ||
|
|
||
| - name: Create artifact for Windows | ||
| shell: bash | ||
| if: runner.os == 'Windows' | ||
| run: | | ||
| export ARTIFACT_NAME="jaq-${{ github.ref_type == 'tag' && github.ref_name || 0 }}-${{ matrix.target }}.zip" | ||
| echo "ARTIFACT_NAME=${ARTIFACT_NAME}" >>"$GITHUB_ENV" | ||
| cd target/${{ matrix.target }}/release | ||
| 7z a "../../../${ARTIFACT_NAME}" jaq.exe ../../../LICENSE-MIT ../../../README.md |
There was a problem hiding this comment.
I am sorry but I do not know how to do it.
|
Hi @eitsupi, thanks again for this PR. Given that this is a quite security-sensitive change, I decided to fully reimplement this functionality in order to understand how to use this safely. This is done in #107. I will prefer my PR to yours and hope that you understand. Still thank you for the inspiration. :) |
Add a new workflow to upload jaq executable files to GitHub releases.
I have tested on my fork.