Fix floats not getting converted to ints after rounding + more strict equality in tests #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
jaq
's handling of floats differs from the behavior specified in the docs:git bisect
shows that this started happening after this commit: dfc6fc0This PR fixes the behavior so floats are converted to ints again after rounding:
I've also tried to tighten up the equality check used during tests so it fails:
This was a little complicated, and I'm not sure if this is even something you want, if it's worth the extra complexity or if the implementation is to your liking. Feedback is welcome, or you can also just close this PR and cherry-pick the float fix yourself if you don't want the test equality changes.