Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overloading MetaAttr to improve type annotation. #184

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

0Hughman0
Copy link
Owner

No description provided.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (2d202dc) to head (7580da5).
Report is 5 commits behind head on 0.3.x.

Files with missing lines Patch % Lines
cassini/meta.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x     #184      +/-   ##
==========================================
- Coverage   83.43%   83.38%   -0.06%     
==========================================
  Files          23       23              
  Lines        1739     1745       +6     
==========================================
+ Hits         1451     1455       +4     
- Misses        288      290       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0Hughman0 0Hughman0 merged commit 98893d9 into 0.3.x Oct 14, 2024
3 of 5 checks passed
@0Hughman0
Copy link
Owner Author

The tests for this change don't show up in coverage because it's tested with mypy.

@0Hughman0 0Hughman0 deleted the overloading-meta-attr branch October 14, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant