feat: support for tweakpane v4 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitschpatrol
force-pushed
the
tweakpane-v4
branch
5 times, most recently
from
efb8bf5 to
141e566
Compare
kitschpatrol
force-pushed
the
tweakpane-v4
branch
from
141e566 to
87e1bab
Compare
kitschpatrol
force-pushed
the
tweakpane-v4
branch
from
87e1bab to
a68ca05
Compare
|
Thank you for the PR! will look into it |
|
I wondered why eslint has to be bumped but
It's very nice of you. 🥰 |
0b5vr
reviewed
Nov 9, 2023
Co-authored-by: 0b5vr <0b5vr@0b5vr.com>
0b5vr
reviewed
Nov 9, 2023
| @@ -88,6 +86,6 @@ RotationInputPluginQuaternionParams | |||
| pickerLayout: picker ?? 'popup', | |||
| value, | |||
| viewProps: viewProps, | |||
| } ); | |||
| } ) as unknown as ValueController<Quaternion>; // TODO; | |||
There was a problem hiding this comment.
nice TODO. I couldn't come up with a viable solution.
|
Thanks for sharing your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this plugin.
I ported it to Tweakpane 4.x. This is a breaking change for users of Tweakpane 3.x.
The updates were mostly based on the following documentation:
I made some minor structural changes to more closely reflect the tweakpane plugin-template.