Skip to content

Commit

Permalink
MIPS: PCI: Use struct list_head lists
Browse files Browse the repository at this point in the history
Rather than open-coding a linked list implementation, make use of the
one in linux/list.h.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14340/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
paulburton authored and ralfbaechle committed Oct 6, 2016
1 parent d05c513 commit 23dac14
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
3 changes: 2 additions & 1 deletion arch/mips/include/asm/pci.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/

#include <linux/ioport.h>
#include <linux/list.h>
#include <linux/of.h>

/*
Expand All @@ -25,7 +26,7 @@
* single controller supporting multiple channels.
*/
struct pci_controller {
struct pci_controller *next;
struct list_head list;
struct pci_bus *bus;
struct device_node *of_node;

Expand Down
9 changes: 4 additions & 5 deletions arch/mips/pci/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@
/*
* The PCI controller list.
*/

static struct pci_controller *hose_head, **hose_tail = &hose_head;
static LIST_HEAD(controllers);

unsigned long PCIBIOS_MIN_IO;
unsigned long PCIBIOS_MIN_MEM;
Expand Down Expand Up @@ -193,8 +192,8 @@ void register_pci_controller(struct pci_controller *hose)
goto out;
}

*hose_tail = hose;
hose_tail = &hose->next;
INIT_LIST_HEAD(&hose->list);
list_add(&hose->list, &controllers);

/*
* Do not panic here but later - this might happen before console init.
Expand Down Expand Up @@ -248,7 +247,7 @@ static int __init pcibios_init(void)
pcibios_set_cache_line_size();

/* Scan all of the recorded PCI controllers. */
for (hose = hose_head; hose; hose = hose->next)
list_for_each_entry(hose, &controllers, list)
pcibios_scanbus(hose);

pci_fixup_irqs(pci_common_swizzle, pcibios_map_irq);
Expand Down

0 comments on commit 23dac14

Please sign in to comment.