[Chore] sopt-makers#159 - 코드리뷰 반영

0inn · Apr 19, 2023 · a01c3c5 · a01c3c5
1 parent be51ed2
commit a01c3c5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/SOPT-iOS/Projects/Features/AttendanceFeature/Sources/AttendanceScene/VC/AttendanceVC.swift b/SOPT-iOS/Projects/Features/AttendanceFeature/Sources/AttendanceScene/VC/AttendanceVC.swift
@@ -153,6 +153,12 @@ public class AttendanceVC: UIViewController, AttendanceViewControllable {
         self.bindViewModels()
         self.setObserver()
     }
+
+    public override func viewWillDisappear(_ animated: Bool) {
+        super.viewWillDisappear(animated)
+
+        NotificationCenter.default.removeObserver(self)
+    }
 }
 
 // MARK: - UI & Layouts

diff --git a/...Projects/Features/AttendanceFeature/Sources/ShowAttendanceScene/VC/ShowAttendanceVC.swift b/...Projects/Features/AttendanceFeature/Sources/ShowAttendanceScene/VC/ShowAttendanceVC.swift
@@ -214,7 +214,7 @@ extension ShowAttendanceVC {
     }
 
     /// 하단 출석하기 버튼 (비)활성화
-    private func setAttendanceButton(isEnabled: Bool, title: String? = "") {
+    private func setAttendanceButton(isEnabled: Bool, title: String? = nil) {
         attendanceButton.isEnabled = isEnabled
         attendanceButton.setTitle(title, for: .normal)
     }