avoid altering the file when there are ts errors (#107)

0no-co · Oct 28, 2023 · 3558964 · 3558964
1 parent 71fcdc9
commit 3558964
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.changeset/popular-clocks-count.md b/.changeset/popular-clocks-count.md
@@ -0,0 +1,5 @@
+---
+'@0no-co/graphqlsp': patch
+---
+
+Correctly bail when file has typescript errors
diff --git a/packages/graphqlsp/src/diagnostics.ts b/packages/graphqlsp/src/diagnostics.ts
@@ -328,12 +328,10 @@ export function getGraphQLDiagnostics(
         scalars,
         baseTypesPath
       ).then(({ success }) => {
-        if (!success) return undefined;
+        if (!success || hasTSErrors) return;
 
         source = getSource(info, filename);
-        if (!source) return undefined;
-
-        if (isFileDirty(filename, source) && !hasTSErrors) {
+        if (!source || isFileDirty(filename, source)) {
           return;
         }