Skip to content

Commit

Permalink
Merge pull request ruby#154 from 0x1eef/unneeded_freeze
Browse files Browse the repository at this point in the history
No longer neccessary to call `String#freeze` on string literals.
  • Loading branch information
hsbt authored Sep 19, 2023
2 parents 96c3dce + 5a986c1 commit beb20c0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/net/http.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,7 @@ def proxy_from_env?
def proxy_uri # :nodoc:
return if @proxy_uri == false
@proxy_uri ||= URI::HTTP.new(
"http".freeze, nil, address, port, nil, nil, nil, nil, nil
"http", nil, address, port, nil, nil, nil, nil, nil
).find_proxy || false
@proxy_uri || nil
end
Expand Down
8 changes: 4 additions & 4 deletions lib/net/http/generic_request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def initialize(m, reqbody, resbody, uri_or_path, initheader = nil) # :nodoc:
raise ArgumentError, "no host component for URI" unless (hostname && hostname.length > 0)
@uri = uri_or_path.dup
host = @uri.hostname.dup
host << ":".freeze << @uri.port.to_s if @uri.port != @uri.default_port
host << ":" << @uri.port.to_s if @uri.port != @uri.default_port
@path = uri_or_path.request_uri
raise ArgumentError, "no HTTP request path given" unless @path
else
Expand Down Expand Up @@ -212,15 +212,15 @@ def update_uri(addr, port, ssl) # :nodoc: internal use only
return unless @uri

if ssl
scheme = 'https'.freeze
scheme = 'https'
klass = URI::HTTPS
else
scheme = 'http'.freeze
scheme = 'http'
klass = URI::HTTP
end

if host = self['host']
host.sub!(/:.*/m, ''.freeze)
host.sub!(/:.*/m, '')
elsif host = @uri.host
else
host = addr
Expand Down

0 comments on commit beb20c0

Please sign in to comment.