Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Turndown to latest version #56

Closed
ngirard opened this issue Mar 19, 2020 · 2 comments · Fixed by #64
Closed

Bump Turndown to latest version #56

ngirard opened this issue Mar 19, 2020 · 2 comments · Fixed by #64

Comments

@ngirard
Copy link

ngirard commented Mar 19, 2020

Hey,
I've just discovered this extension and I'm very satisfied with its options and functionalities: thanks for your work !

I saw that Turndown recently released a new major version: would you mind including it to a new version of c-s-a-m ?

Cheers!
@0x6b
Copy link
Owner

0x6b commented Mar 20, 2020

@ngirard thanks a lot for the feedback which motivates me keeping this add-on public. As noted at the Turndown's README, new escaping rules is quite aggressive and it caused a lot of headache while evaluating it last year. Anyway I will try to revisit. Thank you.

@0x6b
Copy link
Owner

0x6b commented Mar 20, 2020

One question; do you have particular reason/feature for requesting upgrade? I know latest would be greatest but if you have any let me know. Thanks!

0x6b added a commit that referenced this issue May 30, 2020
@0x6b
chore: update deps
6a05412 
Closes #21
Closes #56
@0x6b 0x6b mentioned this issue May 30, 2020
Merged
@0x6b 0x6b closed this as completed in #64 May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: update dependencies 0x6b/copy-selection-as-markdown
2 participants
@ngirard @0x6b