Use npm config when generating the npm lockfile #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x80
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks @laurence79 this looks great! If you could fix these minor things I'll try to publish it soon.
| import defaults from "@npmcli/config/lib/definitions/index.js"; | ||
|
|
||
| export async function loadNpmConfig({ npmPath }: { npmPath: string }) { | ||
| const conf = new Config({ |
There was a problem hiding this comment.
Nitpick; I don't think saving these 2 characters is worth making things less readable. I typically avoid abbreviations
There was a problem hiding this comment.
Understood, addressed.
.DS_Store
Outdated
There was a problem hiding this comment.
Seems like I forgot to add this to .gitignore. Could you please add it and remove this file?
There was a problem hiding this comment.
Slightly embarrassed that this one got committed 😳
Removed and .gitignore updated.
|
@0x80 comments addressed, cheers! |
0x80
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great tool!
I've just started to use it within a corporate environment and found that when using npm as the package manager, the generate lock file stage can fail if the environment isn't using the default https://registry.npmjs.org repo.
This PR addresses that by loading the npm config, using @npmcli/config and passing that to Arborist.
I've validated the approach using patch-package in the environment in question.