-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase exec max buffer size to support large amounts of files #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR 👍 One small change..
I will also change the title of the PR so it can be merged as a descriptive commit message.
@0x80 Thank you for the quick verification! I've reviewed the comment, and I agree that "options" seems better than "option." It has been updated :) |
@0x80 Additional note: Thanks to the package you've created, we've been able to develop numerous common packages within our monorepo, resulting in a significant reduction of duplicated code. We wanted to take this opportunity to express our heartfelt gratitude! 👍 |
@jieey1140 I'm happy to hear that people find it useful. My next step is to get it integrated into the official firebase-tools deploy command, as it allows for running the emulator still with changes hot reloading, but I'm a little swamped with other work so I don't know when I'll give that a try :) |
I have released version 1.3.3 with this change |
@0x80 Thank you. I've verified that the build was successful without any errors. Have a great day! |
I'm going to build the nestjs app as isolate and use it in firebase deploy.
The following error occurs when executing isolation after nest build.
We have identified that the excessive number of src files is causing issues, so we have increased the maxBuffer size in exec to accommodate repositories with a large number of files. (200KB(Default) -> 10MB)
After making this change and conducting tests, we have confirmed that the (JavaScript compiled) environment now compiles successfully!