Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ESM only and improve things #30

Merged
merged 28 commits into from
Nov 27, 2023
Merged

Export ESM only and improve things #30

merged 28 commits into from
Nov 27, 2023

Conversation

0x80
Copy link
Owner

@0x80 0x80 commented Nov 27, 2023

The CJS build did not work because of ESM dependencies, so I decided to only export ESM. An app using isolate from a CJS environment can use a dynamic import.

  • Replace lodash-es with ramda (since it is already a dependency for the pnpm modules, and is an improvement)
  • Fix dev dependencies that should have been regular deps
  • Remove path alias, since it is unnecessary complexity for a mostly flat codebase like this
  • Export a type describing the module exports, so that we can cast the result of the firebase-tools dynamicImport function.

@0x80 0x80 changed the title Export ESM only and improve fuction interface Export ESM only and improve things Nov 27, 2023
@0x80 0x80 merged commit 42407e6 into main Nov 27, 2023
1 check passed
@0x80 0x80 deleted the topic/1126-export-esm-only branch December 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant