Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard error #1693

Closed
shizunge opened this issue Jan 17, 2025 · 10 comments
Closed

Dashboard error #1693

shizunge opened this issue Jan 17, 2025 · 10 comments
Assignees
Labels
🐞 bug Something isn't working
Milestone

Comments

@shizunge
Copy link
Contributor

Blocky version 0.25
Dashboard version: 57b1bdb

3 panels showed bad_data

  • Avg response time
  • Cache hit/miss rate
  • Prefetch count

Image

(Actually the dashboard had the same problem with blocky 0.24 too.)

@shizunge
Copy link
Contributor Author

Also Denylist by group does not look correct.

blocky_denylist_cache should be blocky_denylist_cache_entries in v0.25

@niouniou49
Copy link

niouniou49 commented Jan 18, 2025

HI here
what is see compared to 0.24, the following panels are KO , i looked in details in formula
i was able to fix the others panels but 4 of them seems problematic, see below

  • average resp time is KO -->"blocky_request_duration_ms_sum" and "blocky_request_duration_ms_count" are not working
  • cache hit/miss ratio--->"blocky_cache_hit_count" and "blocky_cache_miss_count" are not working
  • -prefetch hit ratio---> "blocky_prefetch_hit_count" and "blocky_cache_hit_count" are not working
  • request duration (upstream)---> blocky_request_duration_ms_bucket

can you pleaseadvice on new items names if renamed in 0.25 compared to 0.24

try to fix stuff using this list here : https://0xerr0r.github.io/blocky/latest/prometheus_grafana/
but not sure how to mirror

  • blocky_request_duration_ms_bucket
  • blocky_request_duration_ms_sum
  • blocky_request_duration_ms_count
  • blocky_cache_hit_count
  • blocky_cache_miss_count
Image

@shizunge
Copy link
Contributor Author

@niouniou49 based on the screenshot, it seems it is an old version dashboard. The panel orders are different.

The latest in the repo seems designed to work with both old and new metrics. But there are bugs in some query expressions.

@niouniou49
Copy link

hi here
was someone able to correct the broken panel? specially the 'avg response time' ?

@0xERR0R 0xERR0R self-assigned this Jan 20, 2025
@0xERR0R
Copy link
Owner

0xERR0R commented Jan 20, 2025

please try the latest version on master (a398516)

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Jan 20, 2025
@0xERR0R 0xERR0R added this to the v0.26 milestone Jan 20, 2025
@niouniou49
Copy link

niouniou49 commented Jan 20, 2025 via email

@shizunge
Copy link
Contributor Author

shizunge commented Jan 21, 2025

I see No data in some panels with 0.25 and a398516

  • blocky_prefetchs_total should be blocky_prefetches_total
  • blocky_prefetch_hit_count should be blocky_prefetch_hits_total
  • blocky_cache_hit_count should be blocky_cache_hits_total
  • blocky_cache_miss_count should be blocky_cache_misses_total
  • blocky_request_duration_ms_bucket should be blocky_request_duration_seconds_bucket

@niouniou49
Copy link

niouniou49 commented Jan 22, 2025

all good now thanks @shizunge

Image

@0xERR0R 0xERR0R closed this as completed Jan 24, 2025
@shizunge
Copy link
Contributor Author

This issue is not fixed, because the dashboard in the main branch does not work with v0.25.

Additionally if you want the dashboard to work for both 0.24 and 0.25, it needs extra effort.

@0xERR0R
Copy link
Owner

0xERR0R commented Jan 24, 2025

@shizunge just updated queries, thanks for your hints. I think, support for 0.24 is not necessary, since working version can be checked out for 0.24 tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants